Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splashscreen customization #496

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Splashscreen customization #496

merged 1 commit into from
Jan 4, 2025

Conversation

TheGondos
Copy link
Contributor

@TheGondos TheGondos commented Sep 20, 2024

This PR should probably wait for after the 2024 release.
This adds support for custom load screens via a new scenario parameter "SplashScreen" in the ENVIRONMENT section :

BEGIN_ENVIRONMENT
   System Sol
   Date MJD 51982.0975169074
   SplashScreen lime Images/myawesomelogo.jpg
END_ENVIRONMENT

The first parameter is a color in 0xbbggrr format described as a CSS color (either in #hex or as a color name), followed by the image filename to be shown on the splashscreen.
The color name is case insensitive, I tested with filenames containing spaces and it works OK.
The image is scaled with the same logic as the embedded Orbiter logo.

Since I was messing with State.h, I took the opportunity to replace the error prone char arrays with std::string

End result :
splashscreen

@maxq519
Copy link

maxq519 commented Sep 22, 2024

Why should this wait for after the 2024 release? Seems like a relatively minor feature in terms of code, but would be really cool to have.

@TheGondos
Copy link
Contributor Author

TheGondos commented Sep 27, 2024

We need to freeze features or we'll never release a new version...
I'm not really satisfied with the syntax for the color but I don't want to invest more time in this before I get some feedback on the feature as a whole.
There are some topics to address : what happens with different screen ratios, do we need to be able to move the text...

@TheGondos TheGondos marked this pull request as ready for review January 2, 2025 14:57
@TheGondos
Copy link
Contributor Author

With the 2024 version now out, it's time to get the ball rolling again,
I didn't find any document describing the .scn file format to add this to. Any idea where I could put it?

@Xyon
Copy link
Member

Xyon commented Jan 4, 2025

With the 2024 version now out, it's time to get the ball rolling again, I didn't find any document describing the .scn file format to add this to. Any idea where I could put it?

https://github.com/orbitersim/orbiter/blob/main/Doc/Orbiter%20Developer%20Manual/SCENARIO.tex ?

@TheGondos
Copy link
Contributor Author

Rebased to latest main + documentation updated

@Xyon Xyon merged commit 4af3660 into orbitersim:main Jan 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants