Replace logger.exit(...) from the internals #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
approved these changes
Sep 14, 2024
|
@xarses you will need to sign the DCO to merge this fully - click on the little "Details" next to the Robot that says "DCO" in the checks section. |
Replace with raise ValueError instead so that the caller has the option to handle the problem as they desire. Fixes: oras-project#154 Signed-off-by: Andrew Woodward <[email protected]>
xarses
force-pushed
the
raise_logger
branch
from
fda9d0b to
c761fcf
Compare
|
just signed-off-by? should be good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace with raise ValueError instead so that the caller has the option to handle the problem as they desire.
Fixes: #154