implement review feedback

Signed-off-by: tarilabs <[email protected]>
oras-project · Jun 25, 2024 · 722e033 · 722e033
1 parent 154e1c7
commit 722e033
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/auth-tests.yaml b/.github/workflows/auth-tests.yaml
@@ -23,9 +23,13 @@ jobs:
           registry_port: 5000
           with_auth: true
           REGISTRY_AUTH: "{htpasswd: {realm: localhost, path: /etc/docker/registry/auth.htpasswd}}"
+          REGISTRY_HTTP_TLS_CERTIFICATE: "/etc/docker/registry/server.cert"
+          REGISTRY_HTTP_TLS_KEY: "/etc/docker/registry/server.key"
           REGISTRY_STORAGE_DELETE_ENABLED: "true"
         run: |
            htpasswd -cB -b auth.htpasswd myuser mypass
            cp auth.htpasswd /etc/docker/registry/auth.htpasswd
+           apk add openssl
+           openssl req -newkey rsa:4096 -nodes -sha256 -keyout /etc/docker/registry/server.key -x509 -days 365 -out /etc/docker/registry/server.cert
            registry serve /etc/docker/registry/config.yml & sleep 5
            echo $PWD && ls $PWD && make test
diff --git a/oras/tests/test_oras.py b/oras/tests/test_oras.py
@@ -146,7 +146,7 @@ def test_directory_push_pull_selfsigned_auth(
     Test push and pull for directory using a self-signed cert registry (`tls_verify=False`) and basic auth (`auth_backend="basic"`)
     """
     client = oras.client.OrasClient(
-        hostname=registry, insecure=True, tls_verify=False, auth_backend="basic"
+        hostname=registry, tls_verify=False, auth_backend="basic"
     )
     res = client.login(
         hostname=registry,