Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace some micronaut-core tests with micronaut-test to reduce integration test time #552

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

behnazh-w
Copy link
Member

@behnazh-w behnazh-w commented Nov 9, 2023

We use micronaut-core in the integration tests a few times but this project takes a long time to analyze because it produces many artifacts, which we download and verify as part of the provenance verification.

This PR reduces the execution time of the integration tests by making the following changes:

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 9, 2023
@behnazh-w behnazh-w changed the title test: replace some micronaut-core tests with micronaut-test to reduce… test: replace some micronaut-core tests with micronaut-test to reduce integration test time Nov 9, 2023
@behnazh-w behnazh-w force-pushed the remove-expensive-CI-tests branch from 986ef5d to f2fa558 Compare November 9, 2023 03:40
@behnazh-w behnazh-w force-pushed the remove-expensive-CI-tests branch from f2fa558 to 81aa4f2 Compare November 9, 2023 04:05
@behnazh-w behnazh-w marked this pull request as ready for review November 9, 2023 04:57
@behnazh-w behnazh-w requested a review from tromai as a code owner November 9, 2023 04:57
Copy link
Member

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. LGTM

@behnazh-w behnazh-w merged commit 9e90ab1 into staging Nov 13, 2023
10 checks passed
@tromai tromai deleted the remove-expensive-CI-tests branch November 13, 2023 05:20
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
… integration test time (#552)

We use the micronaut-core project in the integration tests a few times but this project takes a long time to analyze because it produces many artifacts, which we download and verify as part of the provenance verification.

This PR reduces the execution time of the integration tests by making the following changes:

* Using micronaut-core only once and checking the analysis result.
* Using micronaut-test instead of micronaut-core in the following tests.
* Commenting out the test for Gradle dependencies as it requires fixing issue #60.

Signed-off-by: behnazh-w <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants