test: add update option to integration script #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
reviewed
Nov 6, 2023
behnazh-w
reviewed
Nov 6, 2023
tromai
reviewed
Nov 13, 2023
tromai
approved these changes
Nov 13, 2023
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
542-add-integration-test-updater
branch
from
43b870e to
b4d895c
Compare
behnazh-w
changed the title
behnazh-w
approved these changes
Nov 13, 2023
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a way of automatically updating the expected results used by the integration tests, closing #542.
The initial implementation achieves this by replacing all
pythoncommands with a variable that can be overridden when the integration test script is passed a specific third argument, thereby performing a copy operation on the two file arguments that would otherwise be compared. At the current time, this avoids performing copy operations on other possiblepythoncommands by relying on the fact that only comparison commands use three arguments, with arguments 2 and 3 being files.Usage:
Command:
make integration-tests-update