Add Makefile dependencies for scripts/zfs-tests.sh -c

[rrevans]

This updates the Makefile to be more correct for parallel make.

Adding explicit dependencies forces make to build all outputs before running the script to populate tests/zfs-tests/bin.

Really this target only needs to depend on targets used by tests/zfs-tests/include/commands.cfg, but waiting for primary automake targets is easier and more straightforward.

Without this, parallel make might install symlinks before all outputs are built. This is problematic when also doing sudo make install afterward as that step repeats this step causing some files to end up owned by root. That ultimately confuses ZTS into adding non-root test users to the root group causing test breakage.

Fixes #16030

Motivation and Context

Using make -j32 causes flakiness when also doing sudo make install before running ZTS.

See the debugging quest at #16030 for the full story, but also the Makefile should be correct for parallel builds.

Description

Adds the automake targets PROGRAMS, DATA, and SCRIPTS to scripts-all-local to force this step to run after all of the primary targets are built.

How Has This Been Tested?

Ran make -j32 after make distclean and observed that scripts/zfs-tests.sh -c ran after primary targets as expected.

Types of changes

This is a Makefile-only change.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[behlendorf]

Thanks for the clear walk through in #16030 about exactly how this can happen. That makes perfect sense, as does the fix to add the required missing dependencies. Nice job getting to the bottom of this!