mwan3: Add support for nslookup track method #25676
Open
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please bump the PKG_VERSION with this commit so we have a new Version |
Sure thing. Do/can you squash on merging or do you want it squashed here before you merge? |
|
Please make sure we only have one commit. Then I just have to press merge. |
brianjmurrell
force-pushed
the
nslookup-method
branch
from
ba182e9 to
9c9023c
Compare
feckert
reviewed
Jan 9, 2025
| @@ -322,11 +328,17 @@ main() { | |||
| fi | |||
| ;; | |||
| nping-*) | |||
| WRAP nping -c $count $track_ip --${FAMILY#nping-} > $TRACK_OUTPUT & | |||
| WRAP nping -${FAMILY#ipv} -c $count $track_ip --${track_method#nping-} > $TRACK_OUTPUT & | |||
There was a problem hiding this comment.
I don't like that. That must be moved to a separate commit with a description of what you are fixing there
There was a problem hiding this comment.
Do you mean separate commit in this PR or seperate/new PR?
There was a problem hiding this comment.
You could add this to this PR. But in a separate commit.
The IP address family is a single dash option and one of 4 or 6, not tcp or udp. Signed-off-by: Brian J. Murrell <[email protected]>
Signed-off-by: Brian J. Murrell <[email protected]>
brianjmurrell
force-pushed
the
nslookup-method
branch
from
9c9023c to
9f0f210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @feckert
Compile tested: x86_64, 23.05.5
Description:
In cases where ICMP ECHO is blocked by the ISP or perhaps even just de-prioritized, there can be a lot of ping failures when the link is perfectly fine. In such cases, doing a DNS query is much more reliable so add a link-test method to use nslookup to do a DNS query.
Also, fix a couple of small bugs in the nping method.