[fix] Remove global CSS rules to avoid conflicts #303 Refactored CSS to prevent global styling conflicts with downstream projects. Fixes #303 #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #303 .
Description of Changes
The initial issue was that CSS styles were being applied globally using the * selector, which can cause conflicts in larger projects. Here's how I fixed it:
Created a scoped container structure:
Added .netjsongraph-container as main wrapper
Added #graphChartContainer for the graph content
This contains styles to just these elements instead of affecting entire page
Fixed height/positioning issue:
Set proper html/body height to 100%
Made container absolute positioned with full dimensions
This ensures graph fills available space correctly
Updated JavaScript:
This approach prevents style leaks while maintaining the original functionality.
@pandafy please review this pull request.
I have made appropriate changes to fix the issue.