feat: support ScopedPersistent<v8::Context>

openwebf · Aug 14, 2024 · b67f643 · b67f643
1 parent 903550a
commit b67f643
Show file tree

Hide file tree

Showing 11 changed files with 54 additions and 408 deletions.
diff --git a/bridge/CMakeLists.txt b/bridge/CMakeLists.txt
@@ -575,7 +575,6 @@ elseif ($ENV{WEBF_JS_ENGINE} MATCHES "v8")
     bindings/v8/wrapper_type_info.cc
     bindings/v8/v8_interface_bridge_base.cc
     bindings/v8/v8_initializer.cc
-#    bindings/v8/platform/script_state.cc
     bindings/v8/platform/scoped_persistent.h
     bindings/v8/platform/v8_per_context_data.cc
     bindings/v8/platform/v8_per_isolate_data.cc

diff --git a/bridge/bindings/v8/platform/scoped_persistent.h b/bridge/bindings/v8/platform/scoped_persistent.h
@@ -28,7 +28,7 @@ class ScopedPersistent {
 
   ~ScopedPersistent() { Clear(); }
 
-  ALWAYS_INLINE v8::Local<T> NewLocal(v8::Isolate* isolate) const {
+  inline v8::Local<T> NewLocal(v8::Isolate* isolate) const {
     return v8::Local<T>::New(isolate, handle_);
   }
 
@@ -66,7 +66,7 @@ class ScopedPersistent {
     return handle_ == other;
   }
 
-  ALWAYS_INLINE v8::Persistent<T>& Get() { return handle_; }
+  inline v8::Persistent<T>& Get() { return handle_; }
 
  private:
   v8::Persistent<T> handle_;

diff --git a/bridge/bindings/v8/platform/script_state.cc b/bridge/bindings/v8/platform/script_state.cc