libnss_tcb: Disallow potentially-malicious user names in getspnam(3). #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besser82
force-pushed
the
topic/besser82/nss_check_username
branch
3 times, most recently
from
2d5c00b to
c685e25
Compare
|
@ldv-alt This should be an easy one. |
solardiz
requested changes
Dec 20, 2024
There was a problem hiding this comment.
I think you've spotted something we really ought to fix, but the code needs further revision.
I don't recall exactly why we didn't have this sort of checks before. It's weird we allowed even ../something. I suppose we expect(ed) that programs would normally use getpwnam first and only proceed to getspnam for existing usernames.
besser82
force-pushed
the
topic/besser82/nss_check_username
branch
2 times, most recently
from
9dfddfc to
e68b446
Compare
|
@solardiz, rebased onto main. |
IEEE Std 1003.1-2001 allows only the following characters to appear in group- and usernames: letters, digits, underscores, periods, <at>-signs (@), and dashes. The name may not start with a dash or an "@" sign. The "$" sign is allowed at the end of usernames to allow typical Samba machine accounts. Signed-off-by: Björn Esser <[email protected]>
besser82
force-pushed
the
topic/besser82/nss_check_username
branch
from
e68b446 to
30116b9
Compare
ldv-alt
approved these changes
Dec 20, 2024
solardiz
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.