New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: operation name use full path #11

Closed

li-zeyuan wants to merge 1 commit into opentracing-contrib:master from li-zeyuan:master

li-zeyuan commented Aug 26, 2022

No description provided.


          feat: operation name use full path

dfe3569

stuart-mclaren-hpe commented Aug 26, 2022

Are you trying to implement this: #10 ?

(Without a git commit message it's difficult for me to be 100% sure.)

I don't think it will be possible to accept this PR as it currently is: it is not backwards compatible.
So it would break things for existing users.

You can see this by running the unit tests:

$ go test -v ./...
# github.com/opentracing-contrib/go-gin/ginhttp [github.com/opentracing-contrib/go-gin/ginhttp.test]
ginhttp/server_test.go:25:32: cannot use fn (type func(*http.Request) string) as type func(*gin.Context) string in argument to OperationNameFunc

li-zeyuan closed this by deleting the head repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet