Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fec scheme for v2 api #873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcornea
Copy link
Contributor

@mcornea mcornea commented Jan 14, 2025

Updating sriovfec.intel.com group version to match the version the operator creates:

oc api-resources | grep sriovfec
sriovfecclusterconfigs                sfcc                                                                                   sriovfec.intel.com/v2                         true         SriovFecClusterConfig
sriovfecnodeconfigs                   sfnc                                                                                   sriovfec.intel.com/v2                         true         SriovFecNodeConfig

@klaskosk
Copy link
Collaborator

@mcornea It looks like this code is automatically synced using this config so we can't change it manually, we'd have to change that config

@mcornea mcornea force-pushed the update_sriov_fec_group_version branch from 0babeea to 5e5ec1e Compare January 14, 2025 14:51
@mcornea mcornea changed the title Update sriovfec.intel.com group version Update fec scheme for v2 api Jan 14, 2025
@mcornea
Copy link
Contributor Author

mcornea commented Jan 14, 2025

@mcornea It looks like this code is automatically synced using this config so we can't change it manually, we'd have to change that config

Thanks @klaskosk I updated the files using the sync tool.

Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants