Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.32] patch func deploy task for serverless 1.32.0 #750

Conversation

serverless-qe
Copy link

patch for func-deploy task to use midstream specific client built for 1.32.0

Copy link

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serverless-qe
Once this PR has been reviewed and has the lgtm label, please ask for approval from matejvasek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (serverless-1.32@17ac97c). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.32     #750   +/-   ##
==================================================
  Coverage                   ?   59.27%           
==================================================
  Files                      ?      108           
  Lines                      ?    13919           
  Branches                   ?        0           
==================================================
  Hits                       ?     8250           
  Misses                     ?     4865           
  Partials                   ?      804           
Flag Coverage Δ
e2e-test 38.36% <ø> (?)
e2e-test-runtime-go 25.55% <ø> (?)
e2e-test-runtime-node 26.57% <ø> (?)
e2e-test-runtime-python 26.57% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.55% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
unit-tests-macos-latest 48.85% <ø> (?)
unit-tests-ubuntu-latest 49.59% <ø> (?)
unit-tests-windows-latest 48.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.32.0 branch from 5a413d6 to ad4ce5d Compare March 10, 2024 15:42
@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.32.0 branch from ad4ce5d to 7c76848 Compare March 11, 2024 23:17
@jrangelramos
Copy link

merging once images are already public

@jrangelramos jrangelramos merged commit 992c414 into serverless-1.32 Apr 12, 2024
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants