fix s2i on cluster RT tests (knative#2015)

* chore: use smaller s2i nodejs builder Signed-off-by: Matej Vasek <[email protected]> * test: skip python s2i on cluster build test on GH Signed-off-by: Matej Vasek <[email protected]> * fixup: do check at correct place Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]>
openshift-knative · Oct 12, 2023 · f83c0ee · f83c0ee
1 parent 7b09bcd
commit f83c0ee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/builders/s2i/builder.go b/pkg/builders/s2i/builder.go
@@ -36,7 +36,7 @@ import (
 // DefaultName when no WithName option is provided to NewBuilder
 const DefaultName = builders.S2I
 
-var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16"
+var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16-minimal"
 var DefaultQuarkusBuilder = "registry.access.redhat.com/ubi8/openjdk-17"
 var DefaultPythonBuilder = "registry.access.redhat.com/ubi8/python-39"
 

diff --git a/test/oncluster/scenario_runtime_test.go b/test/oncluster/scenario_runtime_test.go
@@ -45,6 +45,9 @@ func TestRuntime(t *testing.T) {
 		for _, builder := range runtimeSupportMap[lang] {
 			if targetBuilder == "" || builder == targetBuilder {
 				t.Run(fmt.Sprintf("%v_%v_test", lang, builder), func(t *testing.T) {
+					if lang == "python" && os.Getenv("GITHUB_ACTIONS") == "true" {
+						t.Skip("skipping python test in GH action because of space requirement")
+					}
 					runtimeImpl(t, lang, builder)
 				})
 			}