-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVLOGIC-516: Update midstream documenation for 1.35.0 #118
base: master
Are you sure you want to change the base?
Conversation
Also implement some version sharing to ease the updates
Add card for enabling-jobs-service.adoc
@domhanak: This pull request references SRVLOGIC-516 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
[[proc-gen-manifests-sw-project-kn-cli]] | ||
== Generating a list of Operator manifests using Knative CLI | ||
|
||
After creating your workflow project, you can use the `gen-manifest` command with `kn workflow` to generate operator manifest files for your workflow project in your current directory. | ||
|
||
This will create a new file in `./manifests` directory in your project. | ||
This will screate a new file in `./manifests` directory in your project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in create
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once Roberto's comment is taken care of.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: domhanak, ricardozanini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Roberto Oliveira <[email protected]>
Co-authored-by: Roberto Oliveira <[email protected]>
Co-authored-by: Roberto Oliveira <[email protected]>
@ricardozanini @krisv @gmunozfe @wmedvede @jakubschwan please check
Also added some extra parametrization to have the updates easier in the future.
Added development support note to upstream tools like web tools, vscode etc.
This resulted in numerous fixes in upstream too, so I sent a PR to sync - apache/incubator-kie-kogito-docs#696