Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Storage Page and information to OCP-V section #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Storage Page and information to OCP-V section #96

wants to merge 1 commit into from
+184 −140

Conversation

rguske
Copy link
Contributor

@rguske rguske commented Jan 4, 2025

The page is providing some high-level but important information for storage in OCP-V . I don't want to create a mirror of our docs but I think it comes in handy having these information quickly available.

Closes: #91

@rbo
Copy link
Collaborator

rbo commented Jan 4, 2025

/ok-to-test

@benito-greybeard-cicd benito-greybeard-cicd
Copy link

💀 There was an error during pre-commit / linter:

An unexpected error has occurred: PermissionError: [Errno 13] Permission denied: '/opt/app-root/src/.cache/pre-commit'

@rbo
Copy link
Collaborator

rbo commented Jan 5, 2025

@rguske Please rebase your branch, this problem is fixed in 5905be9

@rbo
Copy link
Collaborator

rbo commented Jan 5, 2025

rebase done

@benito-greybeard-cicd benito-greybeard-cicd
Copy link

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

@rguske
Copy link
Contributor Author

rguske commented Jan 5, 2025

LGTM

rbo
rbo reviewed Jan 5, 2025
View reviewed changes
content/kubevirt/Storage_CSI.png Outdated Show resolved Hide resolved
content/kubevirt/csi-driver-support.png Outdated Show resolved Hide resolved
content/kubevirt/local-storage.md Show resolved Hide resolved
@benito-greybeard-cicd benito-greybeard-cicd
Copy link

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

@benito-greybeard-cicd benito-greybeard-cicd
Copy link

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

@rbo
Copy link
Collaborator

rbo commented Jan 6, 2025 •
edited
Loading

We should add one topic here, to quota Matthias M.

OCP Virtualization works differently for storage than vSphere and RHV: The reuse of existing storage is the aim by customers across the board but only little is known about the differences in the consumption of storage with OpenShift Virtualization. This reveals to be a major challenge for most of the vSphere to OCP-V projects. In vSphere plain storage consumption, the storage capacity is provided using large volumes (aka described as LUNs) as datastores and then the vmdk "block" devices carved out as files coming from vmfs residing on the datastores. A similar approach is used by RHV. In OCP Virtualization instead, every persistent volume for a virtual disk coming from a block storage must be provided as a real world block storage device. This usually leads to trouble on the OCP nodes as well as on the enterprise storage: the number of PVs used for VMs define the number of block volumes to create on the enterprise storage subsystems, to be handled in SAN mappings, and to be managed by FC/iSCSI and multi-pathing on the OCP nodes.

Source: https://docs.google.com/document/d/1S1ss-GOm97rdGld0NsoZqhDgLiTc5Xhma9sR8K0LLVI/edit?tab=t.0#bookmark=id.szxe3a1g5zj8

What do you think @rguske ?

@rguske
Copy link
Contributor Author

rguske commented Jan 7, 2025

We should add one topic here, to quota Matthias M.

OCP Virtualization works differently for storage than vSphere and RHV: The reuse of existing storage is the aim by customers across the board but only little is known about the differences in the consumption of storage with OpenShift Virtualization. This reveals to be a major challenge for most of the vSphere to OCP-V projects. In vSphere plain storage consumption, the storage capacity is provided using large volumes (aka described as LUNs) as datastores and then the vmdk "block" devices carved out as files coming from vmfs residing on the datastores. A similar approach is used by RHV. In OCP Virtualization instead, every persistent volume for a virtual disk coming from a block storage must be provided as a real world block storage device. This usually leads to trouble on the OCP nodes as well as on the enterprise storage: the number of PVs used for VMs define the number of block volumes to create on the enterprise storage subsystems, to be handled in SAN mappings, and to be managed by FC/iSCSI and multi-pathing on the OCP nodes.

Source: https://docs.google.com/document/d/1S1ss-GOm97rdGld0NsoZqhDgLiTc5Xhma9sR8K0LLVI/edit?tab=t.0#bookmark=id.szxe3a1g5zj8

What do you think @rguske ?

Agree! This is definitely an important information! I'll include it.

@rguske
Copy link
Contributor Author

rguske commented Jan 10, 2025

@rbo I've added the information and highlighted it as important. Please review.

@benito-greybeard-cicd benito-greybeard-cicd
Copy link

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

@rbo
Copy link
Collaborator

rbo commented Jan 10, 2025

@rguske Should we merge it with the https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub/kubevirt/local-storage/ ? To have one Storage and Local Storage as a sub point or included.

@rguske
Copy link
Contributor Author

rguske commented Jan 10, 2025

@rbo local-storage is now merged into storage section. Ready to review.

@benito-greybeard-cicd benito-greybeard-cicd
Copy link

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

rbo
rbo requested changes Jan 10, 2025
View reviewed changes
mkdocs.yml
@@ -252,8 +252,8 @@ nav:
- Descheduler: kubevirt/descheduler/index.md
- Templates: kubevirt/template.md
- Ansible: kubevirt/ansible/README.md
- Networking: kubevirt/networking/index.md
- Local-storage: kubevirt/local-storage.md
- Networking: kubevirt/networking.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was kubevirt/networking/index.md not kubevirt/networking.md !

content/kubevirt/storage.md
Official documentation: [Configuring local storage for virtual machines
](https://docs.openshift.com/container-platform/latest/cnv/cnv_virtual_machines/cnv_virtual_disks/cnv-configuring-local-storage-for-vms.html)

## Create a backing directory on each node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indenting. It should be

  • Configuring local storage for virtual machines
    • Create a backing directory on each node
      • Create MachineConfig

As it was in the orgiginal one.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-10 at 16 21 19

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok the original was not perfect as well:
image

rbo
rbo requested changes Jan 10, 2025
View reviewed changes
content/kubevirt/storage.md
## Configuring local storage for virtual machines

Official documentation: [Configuring local storage for virtual machines
](https://docs.openshift.com/container-platform/latest/cnv/cnv_virtual_machines/cnv_virtual_disks/cnv-configuring-local-storage-for-vms.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rguske #95 - Please fix it as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbo rbo rbo requested changes

Assignees
No one assigned
Labels
ok-for-test-deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add supported OCP CSI drivers and features matrix
2 participants
@rguske @rbo