Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset of permissions check on creation #5012

Open
wants to merge 20 commits into
base: feature/api-tokens
Choose a base branch
from

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jan 7, 2025

Description

This PR adds permission checks around API token creation, and cleans up misc. items from the feature branch, including authorizing API token endpoint properly and stashing the context in order to perform the API token refresh action without explicit permission to do so. This PR is dependent on #4992 to be merged first, and this PR only contains the following changes:

https://github.com/opensearch-project/security/pull/5012/files/aa506e78eb5699d2580e28d4bb0f0060971449e1..e13c055e063ae3e5ee40386a53155e5c65893b58

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 60.86957% with 162 lines in your changes missing coverage. Please review.

Project coverage is 71.24%. Comparing base (0edba23) to head (e13c055).
Report is 10 commits behind head on feature/api-tokens.

Files with missing lines Patch % Lines
...arch/security/action/apitokens/ApiTokenAction.java 43.80% 65 Missing and 3 partials ⚠️
...pensearch/security/http/ApiTokenAuthenticator.java 63.75% 20 Missing and 9 partials ⚠️
...urity/action/apitokens/ApiTokenUpdateResponse.java 0.00% 14 Missing ⚠️
...ction/apitokens/TransportApiTokenUpdateAction.java 22.22% 14 Missing ⚠️
...ensearch/security/privileges/ActionPrivileges.java 83.11% 5 Missing and 8 partials ⚠️
...curity/action/apitokens/ApiTokenUpdateRequest.java 0.00% 6 Missing ⚠️
...earch/security/auditlog/impl/AbstractAuditLog.java 40.00% 3 Missing and 3 partials ⚠️
...y/action/apitokens/ApiTokenUpdateNodeResponse.java 0.00% 4 Missing ⚠️
...nsearch/security/action/apitokens/Permissions.java 60.00% 4 Missing ⚠️
...ch/security/securityconf/DynamicConfigModelV7.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           feature/api-tokens    #5012      +/-   ##
======================================================
- Coverage               71.46%   71.24%   -0.22%     
======================================================
  Files                     334      348      +14     
  Lines                   22552    23256     +704     
  Branches                 3590     3682      +92     
======================================================
+ Hits                    16117    16569     +452     
- Misses                   4642     4856     +214     
- Partials                 1793     1831      +38     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 83.67% <100.00%> (+0.11%) ⬆️
...ecurity/action/apitokens/ApiTokenIndexHandler.java 84.78% <100.00%> (ø)
...y/action/apitokens/ApiTokenIndexListenerCache.java 100.00% <100.00%> (ø)
.../security/action/apitokens/ApiTokenRepository.java 100.00% <100.00%> (ø)
...ecurity/action/apitokens/ApiTokenUpdateAction.java 100.00% <100.00%> (ø)
...g/opensearch/security/authtoken/jwt/JwtVendor.java 88.00% <ø> (-1.10%) ⬇️
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <100.00%> (ø)
...dlic/rest/api/RestApiAdminPrivilegesEvaluator.java 73.07% <100.00%> (+0.52%) ⬆️
...search/security/identity/SecurityTokenManager.java 82.75% <100.00%> (-6.61%) ⬇️
...curity/privileges/PrivilegesEvaluationContext.java 97.43% <100.00%> (+0.13%) ⬆️
... and 12 more

... and 12 files with indirect coverage changes

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho marked this pull request as ready for review January 10, 2025 17:59
@derek-ho derek-ho self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant