-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add completion count into shard level and task level SBP RCA #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
November 10, 2023 19:57
Signed-off-by: Kaushal Kumar <[email protected]>
ansjcy
reviewed
Dec 4, 2023
ansjcy
reviewed
Dec 4, 2023
src/main/java/org/opensearch/performanceanalyzer/rca/configs/SearchBackPressureRcaConfig.java
Outdated
Show resolved
Hide resolved
ansjcy
reviewed
Dec 4, 2023
src/main/java/org/opensearch/performanceanalyzer/rca/configs/SearchBackPressureRcaConfig.java
Show resolved
Hide resolved
deshsidd
reviewed
Dec 5, 2023
src/main/java/org/opensearch/performanceanalyzer/rca/configs/SearchBackPressureRcaConfig.java
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/rca/configs/SearchBackPressureRcaConfig.java
Show resolved
Hide resolved
There are some build errors related to syntax. Please fix and try to build locally |
Signed-off-by: Kaushal Kumar <[email protected]>
ansjcy
previously approved these changes
Dec 8, 2023
ansjcy
previously approved these changes
Dec 12, 2023
deshsidd
approved these changes
Dec 12, 2023
sgup432
reviewed
Dec 18, 2023
.../performanceanalyzer/decisionmaker/deciders/searchbackpressure/SearchBackPressurePolicy.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/rca/configs/SearchBackPressureRcaConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/rca/configs/SearchBackPressureRcaConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kaushal Kumar <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
============================================
+ Coverage 74.39% 74.43% +0.03%
- Complexity 2662 2666 +4
============================================
Files 317 317
Lines 16298 16378 +80
Branches 1277 1282 +5
============================================
+ Hits 12125 12191 +66
- Misses 3659 3671 +12
- Partials 514 516 +2 ☔ View full report in Codecov by Sentry. |
sgup432
reviewed
Dec 20, 2023
src/main/java/org/opensearch/performanceanalyzer/LocalhostConnectionUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kaushal Kumar <[email protected]>
sgup432
approved these changes
Dec 21, 2023
ansjcy
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
github issue: opensearch-project/performance-analyzer#587
Changing logic to take
completionCount
into account at shard and task level to accurately calculate the SBP RCAs.Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.