Added .NET client API guide for the Search API. #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djcarrillo6
requested review from
anirudha,
dblock,
joshuali925,
Xtansia,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
Djcarrillo6
force-pushed
the
feat/guides-search
branch
from
fc1b6e8 to
41723c3
Compare
Xtansia
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Generally looks good @Djcarrillo6! Just some suggestions mainly around conciseness of the code, and changing the example data to match the ruby guide
Djcarrillo6
force-pushed
the
feat/guides-search
branch
from
41723c3 to
b35a592
Compare
Xtansia
requested changes
Oct 18, 2023
Djcarrillo6
force-pushed
the
feat/guides-search
branch
from
b35a592 to
43183df
Compare
Xtansia
requested changes
Oct 18, 2023
Signed-off-by: Djcarrillo6 <[email protected]> Fix setup section in guide. Signed-off-by: Djcarrillo6 <[email protected]> Minor updates to search.md Signed-off-by: Djcarrillo6 <[email protected]> Added requested changes to search.md Signed-off-by: Djcarrillo6 <[email protected]> Added requested changes to search.md opensearch-project#2 Signed-off-by: Djcarrillo6 <[email protected]> Added requested changes to search.md opensearch-project#3 Signed-off-by: Djcarrillo6 <[email protected]>
Djcarrillo6
force-pushed
the
feat/guides-search
branch
from
43183df to
fff7c35
Compare
Xtansia
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides add the API guide on using OpenSearch.NET client to implement the OpenSearch "Search API".
Issues Resolved
Resolves issue #189
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.