Update console_link logic on clearing snapshots with missing repo #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Kurait <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
============================================
+ Coverage 80.49% 80.58% +0.08%
Complexity 3079 3079
============================================
Files 421 421
Lines 15650 15658 +8
Branches 1057 1057
============================================
+ Hits 12598 12618 +20
+ Misses 2408 2396 -12
Partials 644 644
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
peternied and
sumobrian
as code owners
lewijacn
reviewed
Jan 3, 2025
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| job-name: [full-es68source-e2e-test, rfs-default-e2e-test] |
There was a problem hiding this comment.
I have a few concerns here and would like to wait on enabling another Jenkins job on PRs:
- What is the additional tax on PR wait time
- Is this providing much value that our full test isn't covering? We would need to have additional environments on standby like we do for the full test in our current model as well to support this
There was a problem hiding this comment.
Removed for now, we can revisit later
There was a problem hiding this comment.
Sure happy to chat more around this sometime
This reverts commit d49877d. Signed-off-by: Andre Kurait <[email protected]>
lewijacn
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update console_link logic on clearing snapshots with missing repo
Fixes error
Updates GHA to run with both 7.10 and 6.8 tests (will apply after pr is merged)
Issues Resolved
N/A
Testing
Added unit test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.