Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSB on specific working workload commit #1202

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Dec 13, 2024

Description

In opensearch-project/opensearch-benchmark-workloads#514 OSB added waiting for green for cluster operations. This commit fixes the workload on the prior commit since our use case uses a single node cluster that is always in yellow state.

Fixed workload on commit:
opensearch-project/opensearch-benchmark-workloads@440ce4b

Issues Resolved

Testing

See GHA

Check List

  • New functionality includes testing
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes, lets merge this.

@lewijacn
Copy link
Collaborator

In order for these E2E tests to pass you will need to update our console link library which is triggering the OSB workloads, we don't actually use this runTestsBenchmarks.sh currently and I've been considering removing it

Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
@AndreKurait AndreKurait merged commit d45f4f3 into opensearch-project:main Dec 13, 2024
20 checks passed
@AndreKurait AndreKurait deleted the OSB_WaitForGreen branch December 13, 2024 18:42
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (0dd78b3) to head (d3c40d0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1202      +/-   ##
============================================
- Coverage     80.65%   80.64%   -0.02%     
- Complexity     3075     3076       +1     
============================================
  Files           421      421              
  Lines         15609    15610       +1     
  Branches       1053     1053              
============================================
- Hits          12589    12588       -1     
- Misses         2378     2381       +3     
+ Partials        642      641       -1     
Flag Coverage Δ
unittests 80.64% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants