-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding @0ctopus13prime as the maintainer for the k-NN repo #2364
Conversation
Signed-off-by: Navneet Verma <[email protected]>
The error on codeowners file is due to @0ctopus13prime doesn't have write access. He will be added in the write access once we have approval on this PR. |
@opensearch-project/admin can anyone help here to move this adding of maintainer PR to next step. |
Please create a similar ticket like this: And please sync us the vote email chain. Thanks. |
@peterzhuamazon I have created the issue: opensearch-project/.github#257 |
added |
@martin-gaievski , @ryanbogan , @heemin32 , @vamshin to approve the PR as suggested next steps by @peterzhuamazon |
Hi @navneet1v you can merge it anytime now. Thanks. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2364-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 405e5e257c074dc6c608191c5c907ce78a6f06f8
# Push it to GitHub
git push --set-upstream origin backport/backport-2364-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Need manual backport. |
Will do. Not sure on which files it created the conflict. :P |
…h-project#2364) Signed-off-by: Navneet Verma <[email protected]>
PR raised: #2372 |
…2372) Signed-off-by: Navneet Verma <[email protected]>
…h-project#2364) Signed-off-by: Navneet Verma <[email protected]>
…h-project#2364) Signed-off-by: Navneet Verma <[email protected]>
Description
Adding @0ctopus13prime as the maintainer for the k-NN repo
Related Issues
NA
Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] API changes companion pull request created.--signoff
.[ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.