Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @0ctopus13prime as the maintainer for the k-NN repo #2364

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

navneet1v
Copy link
Collaborator

Description

Adding @0ctopus13prime as the maintainer for the k-NN repo

Related Issues

NA

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v
Copy link
Collaborator Author

The error on codeowners file is due to @0ctopus13prime doesn't have write access. He will be added in the write access once we have approval on this PR.

@navneet1v
Copy link
Collaborator Author

@opensearch-project/admin can anyone help here to move this adding of maintainer PR to next step.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jan 3, 2025

Please create a similar ticket like this:
opensearch-project/.github#248

And please sync us the vote email chain.
And ask all the +1 maintainers to approve this PR.
Please DO NOT merge this PR until admin give a co-approval

Thanks.

@peterzhuamazon peterzhuamazon marked this pull request as draft January 3, 2025 20:47
@navneet1v
Copy link
Collaborator Author

@peterzhuamazon I have created the issue: opensearch-project/.github#257

@navneet1v
Copy link
Collaborator Author

And please sync us the vote email chain.

added

@navneet1v
Copy link
Collaborator Author

navneet1v commented Jan 3, 2025

And ask all the +1 maintainers to approve this PR.

@martin-gaievski , @ryanbogan , @heemin32 , @vamshin to approve the PR as suggested next steps by @peterzhuamazon

@rishabh6788 rishabh6788 marked this pull request as ready for review January 7, 2025 23:32
@peterzhuamazon
Copy link
Member

Hi @navneet1v you can merge it anytime now.

Thanks.

@navneet1v navneet1v merged commit 405e5e2 into opensearch-project:main Jan 7, 2025
21 checks passed
@navneet1v navneet1v deleted the new-maintainer branch January 7, 2025 23:51
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2364-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 405e5e257c074dc6c608191c5c907ce78a6f06f8
# Push it to GitHub
git push --set-upstream origin backport/backport-2364-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2364-to-2.x.

@peterzhuamazon
Copy link
Member

Need manual backport.

@navneet1v
Copy link
Collaborator Author

Need manual backport.

Will do. Not sure on which files it created the conflict. :P

@navneet1v
Copy link
Collaborator Author

PR raised: #2372

navneet1v added a commit that referenced this pull request Jan 8, 2025
Gankris96 pushed a commit to Gankris96/k-NN that referenced this pull request Jan 8, 2025
owenhalpert pushed a commit to owenhalpert/k-NN that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants