-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI pipeline update to publish geospatial-client jar #706
CI pipeline update to publish geospatial-client jar #706
Conversation
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
@heemin32 I have checked on the existing pipeline, but I don't see any release logic for publishing production zip || jar. |
@heemin32 @navneet1v Any thought? |
Are you talking about something like this? https://github.com/opensearch-project/opensearch-build |
@heemin32 yes, thanks for the reference, let me look into that. |
Not that I know of. I created a feature branch. https://github.com/opensearch-project/geospatial/actions/runs/12437060284 |
I'm seeing client jar as part of the zip for the plugin in aws maven repo: https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/geospatial/3.0.0.0-SNAPSHOT/. I think this is the desired behavior, but want to confirm that @andy-k-improving @heemin32 |
Half half, the ideal state should be:
Hence I reckon that's good to know we have the jar as part of the zip, but in this PR we are focusing to make sure the client-jar being published as a standalone jar for other project to import, if that make sense. |
* Update pipeline Signed-off-by: Andy Kwok <[email protected]> * Update release note Signed-off-by: Andy Kwok <[email protected]> --------- Signed-off-by: Andy Kwok <[email protected]> (cherry picked from commit ba4e8c1)
* Update pipeline Signed-off-by: Andy Kwok <[email protected]> * Update release note Signed-off-by: Andy Kwok <[email protected]> --------- Signed-off-by: Andy Kwok <[email protected]> (cherry picked from commit ba4e8c1) Co-authored-by: Andy Kwok <[email protected]>
@heemin32 @martin-gaievski |
@andy-k-improving Thank you for the contribution! |
Description
To update the project setup, in order to publish geospatial-client jar for both snapshot and release version into
aws.oss.sonatype.org
during the CI execution with appropriate credential.Related Issues
Resolves #698
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Testplan