Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline update to publish geospatial-client jar #706

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

andy-k-improving
Copy link
Contributor

@andy-k-improving andy-k-improving commented Dec 18, 2024

Description

To update the project setup, in order to publish geospatial-client jar for both snapshot and release version into aws.oss.sonatype.org during the CI execution with appropriate credential.

Related Issues

Resolves #698

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Testplan

# Publish the client Jar into local .m2 and examine the jar. 
gradle :geospatial-client:publishNebulaPublicationToMavenLocal 

Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
@andy-k-improving
Copy link
Contributor Author

@heemin32 I have checked on the existing pipeline, but I don't see any release logic for publishing production zip || jar.
Wonder is that published separately on AWS side?

@andy-k-improving
Copy link
Contributor Author

@heemin32 @navneet1v Any thought?

@heemin32
Copy link
Collaborator

@heemin32 I have checked on the existing pipeline, but I don't see any release logic for publishing production zip || jar. Wonder is that published separately on AWS side?

Are you talking about something like this? https://github.com/opensearch-project/opensearch-build

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Dec 20, 2024

@heemin32 yes, thanks for the reference, let me look into that.
In the meanwhile would that be possible to test this change on Github runner before merging?
Can we somehow trigger the build and publish snapshot workflow here, or we can only test it upon merging to main?

@heemin32
Copy link
Collaborator

heemin32 commented Dec 20, 2024

@heemin32 yes, thanks for the reference, let me look into that. In the meanwhile would that be possible to test this change on Github runner before merging? Can we somehow trigger the build and publish snapshot workflow here, or we can only test it upon merging to main?

Not that I know of. I created a feature branch. feature/client we can merge it there to see how it works I guess.

https://github.com/opensearch-project/geospatial/actions/runs/12437060284

@martin-gaievski
Copy link
Member

I'm seeing client jar as part of the zip for the plugin in aws maven repo: https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/geospatial/3.0.0.0-SNAPSHOT/. I think this is the desired behavior, but want to confirm that @andy-k-improving @heemin32

@andy-k-improving
Copy link
Contributor Author

I'm seeing client jar as part of the zip for the plugin in aws maven repo: https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/geospatial/3.0.0.0-SNAPSHOT/. I think this is the desired behaviour, but want to confirm that @andy-k-improving @heemin32

Half half, the ideal state should be:

  1. The client jar being part of the zip, so GeoSpatial plugin aware of it.
  2. To have the geospatial-client jar distributed separately, so end user (Other OS plugin can be import it via Gradle).
# Gradle file for other OpenSearch plugin which wish to use the IP look up feature.
implementation ('org.opensearch:geospatial-client:3.0.0.0-SNAPSHOT')

Hence I reckon that's good to know we have the jar as part of the zip, but in this PR we are focusing to make sure the client-jar being published as a standalone jar for other project to import, if that make sense.

@heemin32 heemin32 added the backport 2.x Backport PR to 2.x branch label Dec 20, 2024
@heemin32 heemin32 merged commit ba4e8c1 into opensearch-project:main Dec 20, 2024
13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2024
* Update pipeline

Signed-off-by: Andy Kwok <[email protected]>

* Update release note

Signed-off-by: Andy Kwok <[email protected]>

---------

Signed-off-by: Andy Kwok <[email protected]>
(cherry picked from commit ba4e8c1)
heemin32 pushed a commit that referenced this pull request Dec 20, 2024
* Update pipeline

Signed-off-by: Andy Kwok <[email protected]>

* Update release note

Signed-off-by: Andy Kwok <[email protected]>

---------

Signed-off-by: Andy Kwok <[email protected]>
(cherry picked from commit ba4e8c1)

Co-authored-by: Andy Kwok <[email protected]>
@andy-k-improving
Copy link
Contributor Author

@heemin32
Copy link
Collaborator

@andy-k-improving Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport PR to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Expose Geo2IP Enrichment feature to other plugins to standardize OpenSearch IP enrichment offering
3 participants