Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read-only role page to documents #5783 #6806
Add read-only role page to documents #5783 #6806
Changes from 3 commits
f7cda22
09b3275
8c6614b
7e16aa1
62bddf2
696ce56
a4b3dbb
c6bc7a8
066b381
cba0c88
8c22b69
fef5487
a090514
7800af0
f0da1c2
af79268
4905e95
573d5fc
f78bea6
de44581
2bb4a60
1260836
a779b6f
0e2ed28
f1d82f8
bab5e51
6042091
e1ae8c3
6a6acb5
56a28c2
e624102
7e49f43
2217480
17d857d
32aedd6
a3a8bcd
1fbb3df
ef4a8e2
53753e9
04d424f
cc0089f
707223d
ae869e4
e668264
7502ca0
fecc37a
2b7dfe4
f76d141
803aeef
9bc682e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should use "indices." Ask @Naarcha-AWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider explaining each of these. Without knowing the background it is not super obvious what
cluster_composite_ops_ro
is for. Likewise it may not be obvious why you restate the permissions at different levels so you may want to clarify this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scrawfor99 good point, I've expanded on this, let me know if below is better:
Basic read only role
If you are looking to create a role to access OpenSearch Dashboards, view existing dashboards/visualizations and query different indexes, assuming you want the user to have read access to all indexes and tenants, you can use the following permissions.
Cluster permission
Cluster permission is needed to access cluster wide resources like visualizations and dashboards. For read only user you add already created
cluster_composite_ops_ro
permission.Indexes permission
In order to view visualizations, user needs to have access to the index that was used to create it, In this can you can add
read
permission to all (*
) indexes.Tenant permissions
If you are using tenants to separate work area between different teams/projects, visualizations and dashboards are saved in specific tenant. To be able to view these the user needs
read
access to the correct tenant. To keep things more straightforward we are giving user access to all (*
) tenants.