Refactor async calls and minor bug fixes #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 59.88% 61.47% +1.58%
==========================================
Files 33 33
Lines 1623 1599 -24
Branches 288 284 -4
==========================================
+ Hits 972 983 +11
+ Misses 548 518 -30
+ Partials 103 98 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
paulstn and
sumukhswamy
as code owners
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
sumukhswamy
reviewed
Feb 28, 2024
|
|
||
| case AsyncQueryStatus.Failed: | ||
| case AsyncQueryStatus.Cancelled: | ||
| isQueryFulfilled = true; |
There was a problem hiding this comment.
Had a question about this isQueryFulfilled this is set as true here so that the loading stops?
There was a problem hiding this comment.
isQueryFulfilled is an internal flag that keeps a check for cancelQuery. If query is fulfilled either with success or failed status then we will not run cancel query.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* refactor async calls, minor bug fixes Signed-off-by: Shenoy Pratik <[email protected]> * type.ts lint updates and snapshot updates Signed-off-by: Shenoy Pratik <[email protected]> * adding lint error fixes Signed-off-by: Shenoy Pratik <[email protected]> * fix named export for QueryResults Signed-off-by: Shenoy Pratik <[email protected]> * remove default from named export Signed-off-by: Shenoy Pratik <[email protected]> * fix flaky unit test and fix lint issues in QueryResults.test.tsx Signed-off-by: Shenoy Pratik <[email protected]> * fix flaky tests and lint errors Signed-off-by: Shenoy Pratik <[email protected]> * error modal updates Signed-off-by: Shenoy Pratik <[email protected]> * update main.tsx snapshot Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 0e30a8d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Feb 28, 2024
* refactor async calls, minor bug fixes * type.ts lint updates and snapshot updates * adding lint error fixes * fix named export for QueryResults * remove default from named export * fix flaky unit test and fix lint issues in QueryResults.test.tsx * fix flaky tests and lint errors * error modal updates * update main.tsx snapshot --------- (cherry picked from commit 0e30a8d) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#224
#217
#203
#202
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.