Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple datasource sessions #251

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jan 19, 2024

Description

Support for multiple datasource sessions

Issues Resolved

#216

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0709b43) 53.08% compared to head (cdf190c) 53.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   53.08%   53.04%   -0.04%     
==========================================
  Files          33       33              
  Lines        1622     1623       +1     
  Branches      288      288              
==========================================
  Hits          861      861              
- Misses        673      674       +1     
  Partials       88       88              
Flag Coverage Δ
dashboards-query-workbench 53.04% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ps48 added 6 commits January 19, 2024 12:22
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
ps48 added 3 commits January 19, 2024 12:41
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
@sumukhswamy sumukhswamy merged commit 96d5644 into opensearch-project:main Jan 22, 2024
10 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 22, 2024
* support for multiple sessions

Signed-off-by: Shenoy Pratik <[email protected]>

* lint fixes

Signed-off-by: Shenoy Pratik <[email protected]>

* async helperlint fix

Signed-off-by: Shenoy Pratik <[email protected]>

* update default import

Signed-off-by: Shenoy Pratik <[email protected]>

* restore snapshot

Signed-off-by: Shenoy Pratik <[email protected]>

* update snapshots

Signed-off-by: Shenoy Pratik <[email protected]>

* lint fix for prefer named exports

Signed-off-by: Shenoy Pratik <[email protected]>

* fix lint for main.test.tsx

Signed-off-by: Shenoy Pratik <[email protected]>

* remove eslintcache

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 96d5644)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Feb 2, 2024
* support for multiple sessions



* lint fixes



* async helperlint fix



* update default import



* restore snapshot



* update snapshots



* lint fix for prefer named exports



* fix lint for main.test.tsx



* remove eslintcache



---------


(cherry picked from commit 96d5644)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants