Increment version to 2.12 and fix build failure #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build failure (opensearch-project#1281) Signed-off-by: monusingh-1 <[email protected]>
saikaranam-amazon
approved these changes
Dec 12, 2023
| @@ -72,7 +73,7 @@ class TransportReplayChangesAction @Inject constructor(settings: Settings, trans | |||
| TransportWriteAction<ReplayChangesRequest, ReplayChangesRequest, ReplayChangesResponse>( | |||
| settings, ReplayChangesAction.NAME, transportService, clusterService, indicesService, threadPool, shardStateAction, | |||
| actionFilters, Writeable.Reader { inp -> ReplayChangesRequest(inp) }, Writeable.Reader { inp -> ReplayChangesRequest(inp) }, | |||
| EXECUTOR_NAME_FUNCTION, false, indexingPressureService, systemIndices) { | |||
| EXECUTOR_NAME_FUNCTION, false, indexingPressureService, systemIndices, NoopTracer.INSTANCE) { | |||
There was a problem hiding this comment.
Do we have any tracking task for tracer integration?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1296 +/- ##
=========================================
Coverage 76.30% 76.30%
- Complexity 1046 1048 +2
=========================================
Files 141 141
Lines 4785 4785
Branches 526 526
=========================================
Hits 3651 3651
- Misses 782 783 +1
+ Partials 352 351 -1 ☔ View full report in Codecov by Sentry. |
ankitkala
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increment version to 2.12 and fix build failure
Description
Increment version to 2.12 and fix build failure
Following changed the constructor
opensearch-project/OpenSearch@e691df0
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.