Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use async client for delete blob or path in S3 Blob Container #16984

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1d4b85f from #16788.

* Use async client for delete blob or path in S3 Blob Container

Signed-off-by: Ashish Singh <[email protected]>

* Fix UTs

Signed-off-by: Ashish Singh <[email protected]>

* Fix failures in S3BlobStoreRepositoryTests

Signed-off-by: Ashish Singh <[email protected]>

* Fix S3BlobStoreRepositoryTests

Signed-off-by: Ashish Singh <[email protected]>

* Fix failures in S3RepositoryThirdPartyTests

Signed-off-by: Ashish Singh <[email protected]>

* Fix failures in S3RepositoryPluginTests

Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Ashish Singh <[email protected]>
(cherry picked from commit 1d4b85f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jan 9, 2025

❌ Gradle check result for 97c82f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 9, 2025

❕ Gradle check result for 97c82f4: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (8a17b8a) to head (97c82f4).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rg/opensearch/repositories/s3/S3BlobContainer.java 45.45% 6 Missing ⚠️
...org/opensearch/repositories/s3/S3AsyncService.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16984      +/-   ##
============================================
- Coverage     71.85%   71.80%   -0.05%     
- Complexity    65507    65510       +3     
============================================
  Files          5316     5316              
  Lines        305588   305500      -88     
  Branches      44516    44503      -13     
============================================
- Hits         219572   219366     -206     
- Misses        67674    67796     +122     
+ Partials      18342    18338       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashking94 ashking94 merged commit 36faab0 into 2.x Jan 9, 2025
60 of 63 checks passed
@github-actions github-actions bot deleted the backport/backport-16788-to-2.x branch January 9, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant