Delete useless loop in TransportBulkAction$BulkOperation.doRun() #16950
+8
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkewwei
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
kkewwei
force-pushed
the
delete_useless_loop_in_TransportBulkAction
branch
from
9f29f7c to
0e48cc9
Compare
|
❕ Gradle check result for 0e48cc9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16950 +/- ##
============================================
+ Coverage 72.21% 72.42% +0.20%
- Complexity 65289 65402 +113
============================================
Files 5301 5301
Lines 303725 303750 +25
Branches 44008 44011 +3
============================================
+ Hits 219340 219991 +651
+ Misses 66394 65744 -650
- Partials 17991 18015 +24 ☔ View full report in Codecov by Sentry. |
org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock #14289 |
andrross
added
backport 2.x
andrross
reviewed
Jan 8, 2025
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Show resolved
Hide resolved
andrross
approved these changes
Jan 10, 2025
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
kkewwei
force-pushed
the
delete_useless_loop_in_TransportBulkAction
branch
from
0e48cc9 to
7aa62d0
Compare
andrross
approved these changes
Jan 10, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]> (cherry picked from commit fccd6c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The second loop is useless, we can merge it into the first loop. The exist it/ut can cover the changed, I don't know whether I should add additional test about it.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.