Fix case insensitive and escaped query on wildcard #16827
Merged
+213
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HUSTERGS
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
github-actions
bot
added
bug
added 2 commits
December 11, 2024 17:26
Signed-off-by: gesong.samuel <[email protected]>
Signed-off-by: gesong.samuel <[email protected]>
HUSTERGS
force-pushed
the
fix_regex_case_insensitive_query_on_wildcard
branch
from
b33ced2 to
b7629b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16827 +/- ##
=========================================
Coverage 72.26% 72.26%
- Complexity 65257 65277 +20
=========================================
Files 5299 5299
Lines 303490 303520 +30
Branches 43937 43942 +5
=========================================
+ Hits 219321 219348 +27
- Misses 66189 66213 +24
+ Partials 17980 17959 -21 ☔ View full report in Codecov by Sentry. |
msfroh
added
backport 2.x
Signed-off-by: Michael Froh <[email protected]>
|
❌ Gradle check result for 8c7856c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
approved these changes
Jan 10, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* fix case insensitive and escaped query on wildcard Signed-off-by: gesong.samuel <[email protected]> * add changelog Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]> Signed-off-by: Michael Froh <[email protected]> Co-authored-by: gesong.samuel <[email protected]> Co-authored-by: Michael Froh <[email protected]> (cherry picked from commit 5afb92f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As for the comment by @msfroh , It may needs more thorough thinking, so this pr just functionally fixed the problem, the refactoring may leave for the future
Related Issues
Resolves #16754 #16755
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.