Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade HttpCore5/HttpClient5 to support ExtendedSocketOption in HttpAsyncClient #16757

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Upgrade HttpCore5/HttpClient5 to support ExtendedSocketOption in HttpAsyncClient #16757

wants to merge 6 commits into from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Dec 2, 2024 •
edited
Loading

Description

Upgrade the httpcore5 version from 5.2.5 to 5.3, to use the ExtendedSocketOption in highlevelClient.

Related Issues

Resolves #15927

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request labels Dec 2, 2024
@kkewwei kkewwei changed the title upgrade httpcore5/httpclient5 to support ExtendedSocketOption in HttpAsyncClient Upgrade HttpCore5/HttpClient5 to support ExtendedSocketOption in HttpAsyncClient Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

❌ Gradle check result for 94747a6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from 94747a6 to 3187c52 Compare December 2, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

❌ Gradle check result for 3187c52: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from 3187c52 to 27a474b Compare December 2, 2024 16:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

❌ Gradle check result for 27a474b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 10, 2024 •
edited
Loading

@kkewwei I think I find out the issue with upgrades, do you mind if I push a few changes into you pull request? thank you

@reta Of course, please feel free to continue.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c45caf5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update_httpcomponents branch from c45caf5 to 871b787 Compare December 10, 2024 15:22
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 871b787: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update_httpcomponents branch from 871b787 to adff229 Compare December 10, 2024 16:28
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for adff229: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update_httpcomponents branch from adff229 to 04db61a Compare December 10, 2024 18:44
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 04db61a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta removed the >breaking Identifies a breaking change. label Dec 17, 2024
@reta reta force-pushed the update_httpcomponents branch from 04db61a to 6bdb182 Compare December 17, 2024 17:52
@reta
Copy link
Collaborator

reta commented Dec 17, 2024

The issue with Reactor Netty and Upgrade flow is fixed and should be available in 1.1.26 release (verified against 1.1.26-SNAPSHOT): reactor/reactor-netty#3538

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6bdb182: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Dec 18, 2024
Open
Open
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.19.0 Issues and PRs related to version 2.19.0 and removed v2.19.0 Issues and PRs related to version 2.19.0 labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3de626a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta added 2 commits January 14, 2025 16:26
@reta
Add SETTING_H2C_MAX_CONTENT_LENGTH to configure h2cMaxContentLength f…
b466fb8 
…or reactor-netty4 transport

Signed-off-by: Andriy Redko <[email protected]>
@reta
Update Apache HttpCore5 to 5.3.2
0f9ba11 
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the update_httpcomponents branch from 9451e3d to 0f9ba11 Compare January 14, 2025 21:51
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0f9ba11: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Jan 15, 2025
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0f9ba11: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] support ExtendedSocketOption in highlevelClient
3 participants
@kkewwei @reta @sandeshkr419