Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] BugFix: call listener.onFailure on failure to pin the timestamp #16264

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[Backport 2.x] BugFix: call listener.onFailure on failure to pin the timestamp #16264

merged 1 commit into from
Oct 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 58adc18 from #16248.

@github-actions
BugFix: call listener.onFailure on failure to pin the timestamp (#16248)
00a8a53 
Signed-off-by: Sachin Kale <[email protected]>
(cherry picked from commit 58adc18)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 00a8a53: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.73%. Comparing base (c92eb41) to head (00a8a53).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...remotestore/RemoteStorePinnedTimestampService.java 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16264      +/-   ##
============================================
- Coverage     71.78%   71.73%   -0.05%     
+ Complexity    65001    64972      -29     
============================================
  Files          5296     5296              
  Lines        303761   303761              
  Branches      44183    44183              
============================================
- Hits         218061   217915     -146     
- Misses        67498    67649     +151     
+ Partials      18202    18197       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 6e8791b into 2.x Oct 10, 2024
58 of 60 checks passed
@github-actions github-actions bot deleted the backport/backport-16248-to-2.x branch October 10, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gbbafna