Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfigure remote state thread pool count #16245

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Reconfigure remote state thread pool count #16245

merged 3 commits into from
Oct 10, 2024

Conversation

soosinha
Copy link
Member

@soosinha soosinha commented Oct 9, 2024

Description

Configuring the thread pool for remote state read and write in order to increase the thread count.

Related Issues

#16055

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 0ffa818: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jul 3, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for a2e211d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the remote_state_threadpool branch from a2e211d to c66706c Compare October 9, 2024 08:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for c66706c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the remote_state_threadpool branch from c66706c to 1cec60e Compare October 9, 2024 15:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Gradle check result for 1cec60e: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.08%. Comparing base (e7757e7) to head (7f1debb).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16245      +/-   ##
============================================
+ Coverage     71.97%   72.08%   +0.10%     
- Complexity    64771    64784      +13     
============================================
  Files          5302     5302              
  Lines        302473   302472       -1     
  Branches      43699    43699              
============================================
+ Hits         217715   218043     +328     
+ Misses        66950    66525     -425     
- Partials      17808    17904      +96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 700ba03: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the remote_state_threadpool branch from 700ba03 to c680d49 Compare October 10, 2024 04:19
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c680d49: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the remote_state_threadpool branch from c680d49 to f126e1d Compare October 10, 2024 04:40
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f126e1d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the remote_state_threadpool branch from f126e1d to 7f1debb Compare October 10, 2024 05:43
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 10, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 7f1debb: SUCCESS

@Bukhtawar Bukhtawar merged commit 691f725 into opensearch-project:main Oct 10, 2024
33 of 34 checks passed
@Bukhtawar Bukhtawar added the backport 2.x Backport to 2.x branch label Oct 10, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@github-actions
Reconfigure remote state thread pool count (#16245)
7a414a5 
* Reconfigure remote state thread pool count

Signed-off-by: Sooraj Sinha <[email protected]>
(cherry picked from commit 691f725)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2024
Merged
Bukhtawar pushed a commit that referenced this pull request Oct 11, 2024
@opensearch-trigger-bot
Reconfigure remote state thread pool count (#16245) (#16268)
89be8a3 
* Reconfigure remote state thread pool count


Signed-off-by: Sooraj Sinha <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@soosinha @dk2k
Reconfigure remote state thread pool count (opensearch-project#16245)
ff518ad 
* Reconfigure remote state thread pool count

Signed-off-by: Sooraj Sinha <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@soosinha @dk2k
Reconfigure remote state thread pool count (opensearch-project#16245)
57fb786 
* Reconfigure remote state thread pool count

Signed-off-by: Sooraj Sinha <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@soosinha @dk2k
Reconfigure remote state thread pool count (opensearch-project#16245)
0a561eb 
* Reconfigure remote state thread pool count

Signed-off-by: Sooraj Sinha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soosinha @Bukhtawar