Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add Get QueryGroup API Logic #15285

Merged
merged 1 commit into from
Aug 18, 2024
Merged

[Backport 2.x] Add Get QueryGroup API Logic #15285

merged 1 commit into from
Aug 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a900a16 from #14709.

@github-actions
Add Get QueryGroup API Logic (#14709)
34a1d6b 
* Add Get QueryGroup API Logic
Signed-off-by: Ruirui Zhang <[email protected]>

* add to changelog
Signed-off-by: Ruirui Zhang <[email protected]>

* fix javadoc
Signed-off-by: Ruirui Zhang <[email protected]>

* change GetQueryGroupAction NAME and add more tests
Signed-off-by: Ruirui Zhang <[email protected]>

* add more unit tests
Signed-off-by: Ruirui Zhang <[email protected]>

* fix spotlessapply
Signed-off-by: Ruirui Zhang <[email protected]>

* addressed comments
Signed-off-by: Ruirui Zhang <[email protected]>

* incorperate comments from create api PR
Signed-off-by: Ruirui Zhang <[email protected]>

* use clustermanager to get the most recent querygroups
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* rebase with main
Signed-off-by: Ruirui Zhang <[email protected]>

* add IT
Signed-off-by: Ruirui Zhang <[email protected]>

* address comments
Signed-off-by: Ruirui Zhang <[email protected]>

* fix IT
Signed-off-by: Ruirui Zhang <[email protected]>
(cherry picked from commit a900a16)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 34a1d6b: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.22222% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.41%. Comparing base (1bee506) to head (34a1d6b).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...earch/plugin/wlm/rest/RestGetQueryGroupAction.java 0.00% 7 Missing ⚠️
...nsearch/plugin/wlm/action/GetQueryGroupAction.java 0.00% 3 Missing ⚠️
...search/plugin/wlm/action/GetQueryGroupRequest.java 76.92% 2 Missing and 1 partial ⚠️
...lugin/wlm/action/TransportGetQueryGroupAction.java 76.92% 2 Missing and 1 partial ⚠️
...pensearch/plugin/wlm/WorkloadManagementPlugin.java 0.00% 2 Missing ⚠️
...ugin/wlm/service/QueryGroupPersistenceService.java 88.88% 0 Missing and 1 partial ⚠️
...va/org/opensearch/cluster/metadata/QueryGroup.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15285      +/-   ##
============================================
- Coverage     71.50%   71.41%   -0.09%     
- Complexity    62808    62816       +8     
============================================
  Files          5145     5150       +5     
  Lines        295183   295251      +68     
  Branches      42988    42990       +2     
============================================
- Hits         211059   210854     -205     
- Misses        66422    66743     +321     
+ Partials      17702    17654      -48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326 jed326 merged commit 6581248 into 2.x Aug 18, 2024
56 checks passed
@andrross andrross deleted the backport/backport-14709-to-2.x branch October 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jed326 jed326 jed326 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jed326