Switch to NodeJS LTS 20 "Iron" #9171

hashworks · 2025-01-10T15:27:57Z

NodeJS 18 "Hydrogen" will be EOL in April 2025.

Closes #8463.

Note: The latest LTS (22 "Jod") fails to build:

ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: /usr/lib/node_modules/yarn/bin/yarn.js run osd:bootstrap
      (node:2565) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
      (Use `node --trace-deprecation ...` to show where the warning was created)
      Node.js process-warning detected:

      DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
          at node:punycode:3:9
          at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
          at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:338:10)
          at loadBuiltinModule (node:internal/modules/helpers:110:7)
          at Function._load (node:internal/modules/cjs/loader:1095:17)
          at TracingChannel.traceSync (node:diagnostics_channel:322:14)
          at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
          at Module.<anonymous> (node:internal/modules/cjs/loader:1335:12)
          at Module.patchedRequire (/build/opensearch-dashboards/src/OpenSearch-Dashboards/node_modules/require-in-the-middle/index.js:217:27)
          at Module.Hook._require.Module.require (/build/opensearch-dashboards/src/OpenSearch-Dashboards/node_modules/require-in-the-middle/index.js:142:27)

Changelog

security: Bump NodeJS to 20.18.1 "Iron" due to pending NodeJS v18 "Hydrogen" EOL (April '25)
security: Bump elastic-apm-node to 4.10.0 to support NodeJS v20

Tests

`yarn test:jest` failures

Due to test failures I'm marking this a draft. Could a reviewer check the test workflow result?

Test Suites: 6 failed, 1 skipped, 474 passed, 480 of 481 total
Tests:       8 failed, 28 skipped, 8 todo, 4667 passed, 4711 total
Snapshots:   1515 passed, 1515 total
Time:        384.071 s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

NodeJS 18 "Hydrogen" will be EOL in April 2025. Closes issue opensearch-project#8463. Note: The latest LTS (22 "Jod") fails to build. Signed-off-by: hashworks <[email protected]>

`3.43.0` fails with v20: ``` error [email protected]: The engine "node" is incompatible with this module. Expected version "^8.6.0 || 10 || 12 || 14 || 16 || 17 || 18 || 19". Got "20.18.1" ``` Signed-off-by: hashworks <[email protected]>

github-actions · 2025-01-10T15:28:33Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions · 2025-01-10T15:28:55Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions · 2025-01-10T15:32:06Z

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

github-actions · 2025-01-10T15:32:45Z

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

github-actions · 2025-01-10T15:34:02Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "Bump NodeJS to 20.18.1 "Iron" due to pending NodeJS v18 "Hydrogen" EOL (April '25)". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-01-10T15:35:32Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-01-10T15:38:32Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "security". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-01-10T15:39:23Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "security". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

hashworks · 2025-01-10T15:42:19Z

Regarding elastic-apm-node: We could go as low as 3.45.0, but I had more test failures with it than with the latest version (4.10.0).

hashworks · 2025-01-10T15:42:44Z

Changelog would be:

security: Bump NodeJS to 20.18.1 "Iron" due to pending NodeJS v18 "Hydrogen" EOL (April '25)
security: Bump elastic-apm-node to 4.10.0 to support NodeJS v20

But it seems I'm not allowed to add it here.

codecov · 2025-01-10T15:54:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.00%. Comparing base (e401613) to head (d49e58c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9171      +/-   ##
==========================================
- Coverage   61.02%   61.00%   -0.03%     
==========================================
  Files        3813     3813              
  Lines       91396    91396              
  Branches    14439    14439              
==========================================
- Hits        55771    55752      -19     
- Misses      32067    32082      +15     
- Partials     3558     3562       +4

Flag	Coverage Δ
Linux_1	`?`
Linux_2	`?`
Linux_3	`?`
Linux_4	`?`
Windows_1	`29.09% <ø> (ø)`
Windows_2	`56.45% <ø> (+0.04%)`	⬆️
Windows_3	`38.03% <ø> (+<0.01%)`	⬆️
Windows_4	`29.03% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AMoo-Miki · 2025-01-10T20:35:19Z

TESTING.md

@@ -27,8 +27,8 @@ In general, we recommend four tiers of tests:


 # Requirements
-* Install the latest NodeJS, [NPM](https://www.npmjs.com/get-npm) and [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)
-    * `nvm install v18.19.0`
+* Install the specified NodeJS, [NPM](https://www.npmjs.com/get-npm) and [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)


Why would we require a "specific" version of Node.js for testing?

If you install the latest NodeJS version (v23) it won't build.

nit: we may want to advise users to simply run nvm install so that they always get the version defined in our .nvmrc in the case these docs get outdated.

Not needed for this change though.

d-rowe · 2025-01-16T00:12:12Z

@hashworks thanks for taking the time to contribute! Taking a look at the build, test, and lint workflow it seems that the lock file may be outdated or generated with the prior node version. Can you quickly verify if thats the case?

d-rowe · 2025-01-16T00:13:46Z

Changelog would be:

security: Bump NodeJS to 20.18.1 "Iron" due to pending NodeJS v18 "Hydrogen" EOL (April '25)

security: Bump elastic-apm-node to 4.10.0 to support NodeJS v20

But it seems I'm not allowed to add it here.

If you add these in the Changelog section in your PR section, the changelog workflow should auto generate and commit these to the changelog file.

hashworks · 2025-01-16T10:05:20Z

If you add these in the Changelog section in your PR section, the changelog workflow should auto generate and commit these to the changelog file.

I'll try again, but doing so caused the Bot Comment Spam above.

github-actions · 2025-01-16T10:06:16Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "security". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

hashworks added 2 commits January 10, 2025 15:45

Switch to NodeJS LTS 20 "Iron"

1a602a8

NodeJS 18 "Hydrogen" will be EOL in April 2025. Closes issue opensearch-project#8463. Note: The latest LTS (22 "Jod") fails to build. Signed-off-by: hashworks <[email protected]>

github-actions bot added the repeat-contributor label Jan 10, 2025

github-actions bot added the failed changeset label Jan 10, 2025

github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jan 10, 2025

AMoo-Miki reviewed Jan 10, 2025

View reviewed changes

github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jan 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to NodeJS LTS 20 "Iron" #9171

Switch to NodeJS LTS 20 "Iron" #9171

hashworks commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

hashworks commented Jan 10, 2025

hashworks commented Jan 10, 2025

codecov bot commented Jan 10, 2025 •

edited

Loading

AMoo-Miki Jan 10, 2025

hashworks Jan 10, 2025 •

edited

Loading

d-rowe Jan 16, 2025

d-rowe commented Jan 16, 2025

d-rowe commented Jan 16, 2025

hashworks commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

Switch to NodeJS LTS 20 "Iron" #9171

Are you sure you want to change the base?

Switch to NodeJS LTS 20 "Iron" #9171

Conversation

hashworks commented Jan 10, 2025 • edited Loading

Changelog

Tests

yarn test:jest failures

Check List

github-actions bot commented Jan 10, 2025

❌ Invalid Changelog Heading

github-actions bot commented Jan 10, 2025

❌ Invalid Changelog Heading

github-actions bot commented Jan 10, 2025

❌ Changelog Entry Missing Hyphen

github-actions bot commented Jan 10, 2025

❌ Changelog Entry Missing Hyphen

github-actions bot commented Jan 10, 2025

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Jan 10, 2025

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Jan 10, 2025

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Jan 10, 2025

❌ Invalid Prefix For Manual Changeset Creation

hashworks commented Jan 10, 2025

hashworks commented Jan 10, 2025

codecov bot commented Jan 10, 2025 • edited Loading

Codecov Report

AMoo-Miki Jan 10, 2025

Choose a reason for hiding this comment

hashworks Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

d-rowe Jan 16, 2025

Choose a reason for hiding this comment

d-rowe commented Jan 16, 2025

d-rowe commented Jan 16, 2025

hashworks commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

❌ Invalid Prefix For Manual Changeset Creation

hashworks commented Jan 10, 2025 •

edited

Loading

`yarn test:jest` failures

codecov bot commented Jan 10, 2025 •

edited

Loading

hashworks Jan 10, 2025 •

edited

Loading