-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166
Open
ArgusLi
wants to merge
16
commits into
opensearch-project:main
Choose a base branch
from
ArgusLi:testid-124-list-saved-queries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166
ArgusLi
wants to merge
16
commits into
opensearch-project:main
from
ArgusLi:testid-124-list-saved-queries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
ArgusLi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
January 9, 2025 18:17
ArgusLi
changed the title
[Discover 2.0 Testing] Create View Saved Queries Test (Test-Id 124: List Saved Queries)
[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query)
Jan 9, 2025
angle943
reviewed
Jan 10, 2025
...rch-dashboards/opensearch-dashboards/apps/query_enhancements/field_display_filtering.spec.js
Show resolved
Hide resolved
angle943
suggested changes
Jan 10, 2025
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js
Outdated
Show resolved
Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js
Outdated
Show resolved
Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js
Outdated
Show resolved
Hide resolved
...search-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries_old_ui.spec.js
Outdated
Show resolved
Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/saved_queries.spec.js
Outdated
Show resolved
Hide resolved
...e-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/utils/saved_queries.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Argus Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9166 +/- ##
=======================================
Coverage 61.01% 61.01%
=======================================
Files 3813 3813
Lines 91401 91401
Branches 14443 14443
=======================================
Hits 55770 55770
Misses 32068 32068
Partials 3563 3563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
angle943
reviewed
Jan 10, 2025
Signed-off-by: Argus Li <[email protected]>
LDrago27
reviewed
Jan 10, 2025
...e-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/utils/saved_queries.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
LDrago27
reviewed
Jan 13, 2025
… old ui and new ui commands Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Cypress test suite for filtering in the Discover page.
Issues Resolved
Closes #8976.
Screenshot
newUICompressed.mp4
oldUICompressed.mp4
Testing the changes
With OSD running, run
yarn run cypress open
. In E2E specs, you will see 2 new test specssaved_queries.spec.js
andsaved_queries_old_ui.spec.js
. Runsaved_queries.spec.js
ifdata.savedQueriesNewUI.enabled: true
in the OSD config, else runsaved_queries_old_ui.spec.js
.Changelog