Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) #9166

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Jan 9, 2025

Description

Adds a Cypress test suite for filtering in the Discover page.

Issues Resolved

Closes #8976.

Screenshot

newUICompressed.mp4
oldUICompressed.mp4

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see 2 new test specs saved_queries.spec.js and saved_queries_old_ui.spec.js. Run saved_queries.spec.js if data.savedQueriesNewUI.enabled: true in the OSD config, else run saved_queries_old_ui.spec.js.

Changelog

  • test: Add cypress integration test for the old and new UI view saved queries.

@ArgusLi ArgusLi changed the title [Discover 2.0 Testing] Create View Saved Queries Test (Test-Id 124: List Saved Queries) [Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) Jan 9, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (e450f4d) to head (6297366).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lugins/data/public/ui/saved_query_form/helpers.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9166   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files        3813     3813           
  Lines       91401    91401           
  Branches    14443    14443           
=======================================
  Hits        55770    55770           
  Misses      32068    32068           
  Partials     3563     3563           
Flag Coverage Δ
Linux_1 29.08% <ø> (ø)
Linux_2 56.45% <ø> (ø)
Linux_3 38.02% <0.00%> (-0.01%) ⬇️
Linux_4 29.03% <ø> (ø)
Windows_1 29.09% <ø> (ø)
Windows_2 56.40% <ø> (ø)
Windows_3 38.03% <0.00%> (ø)
Windows_4 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Saved Queries] TESTID-124: View list of Saved query
3 participants