[Backport 2.x] [Workspace] Add privacy levels to the workspace #9162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add privacy selector UI at create page Signed-off-by: Kapian1234 <[email protected]> * Add privacy settings UI at collaborstors page Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #8907 created/updated * Add privacy settings panel at collaborstors page Signed-off-by: Kapian1234 <[email protected]> * Fix the height of cards at workspace create page Signed-off-by: Kapian1234 <[email protected]> * Refactor workspace creator form with privacyType and setPrivacyType Signed-off-by: Lin Wang <[email protected]> * Resolve some issues Signed-off-by: Kapian1234 <[email protected]> * Add privacy settings control at details page Signed-off-by: Kapian1234 <[email protected]> * Add single star user check for add collaborators modal Signed-off-by: Lin Wang <[email protected]> * Disable save button if the selected privay type remains unchanged at collaborators page Signed-off-by: Kapian1234 <[email protected]> * Fix workspace creator UT Signed-off-by: Lin Wang <[email protected]> * Fix failed snapshots Signed-off-by: Lin Wang <[email protected]> * Add missing UT for workspace form utils Signed-off-by: Lin Wang <[email protected]> * Update UT for useWorkspaceForm Signed-off-by: Lin Wang <[email protected]> * Add unit tests for privacy settings at workspace create and details Signed-off-by: Kapian1234 <[email protected]> * / Signed-off-by: Kapian1234 <[email protected]> * Fix redirect to workspace landing page Signed-off-by: Lin Wang <[email protected]> * Remove changes to configuration files Signed-off-by: Kapian1234 <[email protected]> * Remove changes to configuration files Signed-off-by: Kapian1234 <[email protected]> * Add unit test for notification toasts Signed-off-by: Kapian1234 <[email protected]> * Add test id for privacy setting selector Signed-off-by: Lin Wang <[email protected]> * Add unit test for Collaborators Link at workspace details Signed-off-by: Kapian1234 <[email protected]> * Use constant for collaborators link Signed-off-by: Kapian1234 <[email protected]> * Fix issues of spelling and importing path Signed-off-by: Kapian1234 <[email protected]> * Remove the validation for the existence of an owner in permission settings Signed-off-by: Kapian1234 <[email protected]> * Add test id for privacy setting button in collaborators page Signed-off-by: Lin Wang <[email protected]> * Fix the discard operation Signed-off-by: Kapian1234 <[email protected]> * Add workspace privacy to summary card Signed-off-by: Kapian1234 <[email protected]> * Add additional privacy description at workspace create page Signed-off-by: Kapian1234 <[email protected]> * Remove unit tests related to missing owner in permission settings Signed-off-by: Kapian1234 <[email protected]> * Add permissionEnabled check for summary card Signed-off-by: Kapian1234 <[email protected]> * Disallow * input for user groups Signed-off-by: Kapian1234 <[email protected]> * Rename the converter and move options outside the function Signed-off-by: Kapian1234 <[email protected]> * Add learn more flyout at collaborators page Signed-off-by: Kapian1234 <[email protected]> * Fix unit tests and update snapshots Signed-off-by: Kapian1234 <[email protected]> * Remove the scss file for WorkspacePrivacyFlyout Signed-off-by: Kapian1234 <[email protected]> * Address some issues Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 8d98654) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #9162 +/- ##
==========================================
+ Coverage 60.92% 60.95% +0.03%
==========================================
Files 3808 3811 +3
Lines 91206 91287 +81
Branches 14392 14412 +20
==========================================
+ Hits 55563 55643 +80
Misses 32117 32117
- Partials 3526 3527 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jan 9, 2025
Hailong-am
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8d98654 from #8907.