Disable query assistant when dataset type is not supported #9157
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9157 +/- ##
=======================================
Coverage 61.01% 61.01%
=======================================
Files 3812 3812
Lines 91385 91389 +4
Branches 14438 14439 +1
=======================================
+ Hits 55762 55765 +3
- Misses 32065 32111 +46
+ Partials 3558 3513 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
previously approved these changes
Jan 8, 2025
| isEnabled$: (dependencies) => { | ||
| const query = dependencies.query; | ||
| if (!queryAssistantSupportedDatasetTypes.includes(query.dataset?.type || '')) { | ||
| return new BehaviorSubject(false); |
There was a problem hiding this comment.
Nit: what about simply do:
Suggested change
| return new BehaviorSubject(false); | |
| return of(false); |
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Hailong-am
approved these changes
Jan 9, 2025
SuZhou-Joe
changed the title
kavilla
reviewed
Jan 13, 2025
| @@ -93,6 +93,11 @@ const getAvailableLanguages$ = (http: HttpSetup, data: DataPublicPluginSetup) => | |||
| }) | |||
| ); | |||
|
|
|||
| const queryAssistantSupportedDatasetTypes = [ | |||
| DEFAULT_DATA.SET_TYPES.INDEX, | |||
| DEFAULT_DATA.SET_TYPES.INDEX_PATTERN, | |||
There was a problem hiding this comment.
thanks for doing this but should this be apart of the switch map on line 87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discover with query enhancement now supports varies of dataset: INDEX_PATTERN / INDEXES / S3, while the PPL query generated by query assistant are only supported by opensearch engine, so that we need to disable query assistant for S3 dataset for now.
Issues Resolved
Screenshot
Before
After
20250108162451031.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration