CreateTextFile should override files of different type #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
commented
Nov 12, 2023
rewrite-core/src/main/java/org/openrewrite/text/CreateTextFile.java
Outdated
Show resolved
Hide resolved
timtebeek
commented
Nov 12, 2023
sambsnyd
approved these changes
Nov 13, 2023
rewrite-core/src/main/java/org/openrewrite/text/CreateTextFile.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/text/CreateTextFile.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/text/CreateTextFile.java
Outdated
Show resolved
Hide resolved
timtebeek
deleted the
create_text_file_should_override_different_file_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Allow
CreateTextFileto overwrite files in a different format thanPlainText.What's your motivation?
We recently started parsing
Jenkinsfileas Groovy, which unfortunately broke theCreateTextFileused inModernizeJenkinsfilehttps://github.com/openrewrite/rewrite-jenkins/blob/8914ccd62655d65f2c54e2e40ed6289f13f69542/src/main/resources/META-INF/rewrite/rewrite.yml#L53-L70
Fixes openrewrite/rewrite-jenkins#52
Anything in particular you'd like reviewers to focus on?
Called out below.
Have you considered any alternatives or workarounds?
Not really; looked towards
FindAndReplaceas that also allows text replace regardless of file type.Any additional context