-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite testcontainers to use explicit image and version #433
Conversation
@eddumelendez & @kiview I'm strongly leaning towards only having the testcontainers recipes here and archiving the rewrite-testcontainers repository. I can grant you both contributor rights here all the same. What are your immediate thoughts to that? I'd been wanting to revisit this for a while, but didn't quite get to it. Then I saw these two items this past week which spurred me into action now, to hopefully get migrations for testcontainers going.
We can optionally (but ideally separately) pick up some more of the items in openrewrite/rewrite-testcontainers#1, such as
|
I think the immediate benefit is we are unblocked to add recipes due to the pending tasks about migrating openrewrite/rewrite-testcontainers 👀 . So, 👍🏽 If so, then I can create a backlog of issues in this repository that I have in mind. Thanks for starting this work, @timtebeek ! |
Glad to hear it's appreciated! I've gone ahead and archived rewrite-testcontainers, and sent you an invite to this repository instead. I look forward to working together more here! Feel free to open any issues or pull requests, and label them testcontainers. |
What's changed?
Add recipes to rewrite testcontainers, as rewritten for Rewrite 8 from https://github.com/openrewrite/rewrite-testcontainers
What's your motivation?
Fixes openrewrite/rewrite-testcontainers#1
Anything in particular you'd like reviewers to focus on?
I've crudely stripped out individual recipes and tests where I saw duplication; rather we can just run an aggregate
ExplicitContainerImages
that will match whatever is present. I'll add the other recipes that were present still.Anyone you would like to review specifically?
@eddumelendez @kiview
Have you considered any alternatives or workarounds?
Integrated here such that these recipes can be used from a JUnit Jupiter migration, and themselves reuse other recipes from there.
Any additional context