Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hudson.Util.getPastTimeString Migration Rule #9

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

sghill
Copy link
Collaborator

@sghill sghill commented Jul 16, 2023

What's changed?

Introduced a new rule to automatically move from a deprecated method to a preferred one.

What's your motivation?

Starting to implement rewrite equivalents of the jackpot rules mentioned in Issue #6.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@sghill sghill self-assigned this Jul 16, 2023
@timtebeek
Copy link
Contributor

Did a retry of main to see the error that fails here is also there https://github.com/openrewrite/rewrite-jenkins/actions/runs/5560549004/jobs/10167585707 ; looked at the test but couldn't quite figure out why that started to fail. 🤔

@sghill
Copy link
Collaborator Author

sghill commented Jul 16, 2023

@timtebeek Thanks for taking a look! I think resource ordering my have changed?

I inadvertently had a name collision (3a434c8) with this test recipe (commons-text -> commons-text-api) and a real recipe in src/main/resources (commons-lang3 -> commons-lang3-api). Looks like the test started favoring the main definition.

@sghill sghill merged commit 5e1aa07 into main Jul 17, 2023
@timtebeek timtebeek deleted the hudson-util branch July 17, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants