Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CODEOWNERS generation for invalid teams #50

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Conversation

sghill
Copy link
Collaborator

@sghill sghill commented Sep 2, 2023

What's changed?

Before the file is generated in AddTeamToCodeowners, we verify the team name is valid.

What's your motivation?

Closes #49. Prevents generating unexpected changes.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files
  • I've updated the documentation (if applicable)

@sghill sghill self-assigned this Sep 2, 2023
@sghill sghill merged commit 94d6a49 into main Sep 2, 2023
@sghill sghill deleted the fix/codeowners branch September 2, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CODEOWNERS Generated with excluded team name
1 participant