Adopt the recipe-library Gradle plugin #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might fail to run the Kotlin tests...
sambsnyd
approved these changes
Jun 29, 2023
|
Tests run and pass: https://ge.openrewrite.org/s/zlfsfwsqgn4vi/tests/overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Adopt the recipe-library Gradle plugin from https://github.com/openrewrite/rewrite-build-gradle-plugin
What's your motivation?
Leverage all the plugin offers in terms of standardization, to simplify the build.
Anything in particular you'd like reviewers to focus on?
Might fail to run the Kotlin tests... do we want to run them still for now, or just migrate those over too?
Have you considered any alternatives or workarounds?
No really; this ought to help the pipeline succeed where it now fails on Nebula gpg signing.
Any additional context
For #4