Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override and Exclude Known Team Names #48

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Override and Exclude Known Team Names #48

merged 1 commit into from
Aug 30, 2023

Conversation

sghill
Copy link
Collaborator

@sghill sghill commented Aug 29, 2023

What's changed?

There is now a properties file to provide team name advice for a given artifactId.

What's your motivation?

Fixes #47.

This prevents generating incorrect team names for all artifactIds currently published to the Jenkins Update Center.

Anything in particular you'd like reviewers to focus on?

The approach in general.

Our existing rules already work for 85% of artifactIds in the Jenkins Update Center. The remaining 15% have been fixed or excluded in this PR. Going forward there are strong conventions on how team names are generated, so no further overrides or exclusions should be required.

Anyone you would like to review specifically?

@timtebeek @MarkEWaite

Have you considered any alternatives or workarounds?

Adding additional rules to guess the name, requesting all teams be created, and renaming plugins. Each of these requires additional work from several different folks.

Any additional context

The team names here have been pruned to only those that end in -plugin-developers or clearly mapped to an existing repository. The goal is they would end up listed in CODEOWNERs files, so I thought it was reasonable to include as test data.

I pulled the list of current artifactIds from the Jenkins Update Center API. This overestimates the possible candidates for the recipe in some respects, as plugins are listed individually, but in rare cases multiple plugins are produced from one repo.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files
  • I've updated the documentation (if applicable)

@sghill sghill self-assigned this Aug 29, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good to me. New team names will follow the established convention. The exclusions file covers very nicely the old exceptions.

@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Aug 30, 2023
@sghill sghill merged commit 1a12b66 into main Aug 30, 2023
@sghill sghill deleted the fix/known-teams branch August 30, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect CODEOWNERS file created for Priority Sorter plugin and TestNG plugin
3 participants