Override and Exclude Known Team Names #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
There is now a properties file to provide team name advice for a given artifactId.
What's your motivation?
Fixes #47.
This prevents generating incorrect team names for all artifactIds currently published to the Jenkins Update Center.
Anything in particular you'd like reviewers to focus on?
The approach in general.
Our existing rules already work for 85% of artifactIds in the Jenkins Update Center. The remaining 15% have been fixed or excluded in this PR. Going forward there are strong conventions on how team names are generated, so no further overrides or exclusions should be required.
Anyone you would like to review specifically?
@timtebeek @MarkEWaite
Have you considered any alternatives or workarounds?
Adding additional rules to guess the name, requesting all teams be created, and renaming plugins. Each of these requires additional work from several different folks.
Any additional context
The team names here have been pruned to only those that end in
-plugin-developers
or clearly mapped to an existing repository. The goal is they would end up listed inCODEOWNER
s files, so I thought it was reasonable to include as test data.I pulled the list of current artifactIds from the Jenkins Update Center API. This overestimates the possible candidates for the recipe in some respects, as plugins are listed individually, but in rare cases multiple plugins are produced from one repo.
Checklist
./gradlew licenseFormat