Remove dependency on symbol-annotation
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Once enhancement we can make later is to check the Jenkins version is >= 2.349 so it can be run standalone as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27 by removing the dependency on
symbol-annotation. We do this only for theorg.openrewrite.jenkins.ModernizePluginrecipe and not theorg.openrewrite.jenkins.ModernizePluginForJava8recipe because the latter only bumps the core version up to 2.346.3, and a recent version ofsymbol-annotationis only delivered by core as of 2.349. We tested this by runningorg.openrewrite.jenkins.ModernizePluginagainst jenkinsci/artifact-repository-parameter-plugin@b0a0a4e and verifying that thesymbol-annotationdependency was successfully removed. We did not add any test coverage in this repository becauseorg.openrewrite.java.RemoveDependencyis upstream functionality that is already tested upstream, and similar usages in this repository (e.g., the usage oforg.openrewrite.maven.ChangeDependencyGroupIdAndArtifactIdto changemockito-inlinetomockito-corea few lines above this change) don't have test coverage in this repository either.