Remove usages of Animal Sniffer #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26 by removing any usages of Animal Sniffer annotations. The only annotation that exists in Animal Sniffer is
org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement, so that is the only annotation we remove. We do this only for theorg.openrewrite.jenkins.ModernizePluginrecipe and not theorg.openrewrite.jenkins.ModernizePluginForJava8recipe because Animal Sniffer is still used in Java 8. We tested this by runningorg.openrewrite.jenkins.ModernizePluginagainst jenkinsci/active-directory-plugin@c493ebc and verifying that the Animal Sniffer annotation and its import were successfully removed. We did not add any test coverage in this repository becauseorg.openrewrite.java.RemoveAnnotationis upstream functionality that is already tested upstream, and similar usages in this repository (e.g., the usage oforg.openrewrite.maven.ChangeDependencyGroupIdAndArtifactIdto changemockito-inlinetomockito-corea few lines below this change) don't have test coverage in this repository either.