Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS Enhancements #37

Merged
merged 1 commit into from
Aug 21, 2023
Merged

CODEOWNERS Enhancements #37

merged 1 commit into from
Aug 21, 2023

Conversation

sghill
Copy link
Collaborator

@sghill sghill commented Aug 21, 2023

What's changed?

  • Generate new file with a trailing space so it looks nicer in the git diff
  • Ensure only the .github/CODEOWNERS file is modified
  • Match existing declaration of team even if it includes trailing spaces

What's your motivation?

Followup to #19 to correct some issues after initial run.

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@sghill
Generate CODEOWNERS with newline
c1584bb 
Ensure only the .github/CODEOWNERS file is modified.

Refs: #19
@sghill sghill self-assigned this Aug 21, 2023
@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Aug 21, 2023
@sghill sghill merged commit d528b8c into main Aug 21, 2023
@sghill sghill deleted the bugfix/generate-codeowners-with-newline branch August 21, 2023 16:24
@sghill
Copy link
Collaborator Author

sghill commented Aug 23, 2023

Follow up needed on multi-module projects: jenkinsci/aws-java-sdk-plugin@9e0c12f

@sghill
Copy link
Collaborator Author

sghill commented Aug 23, 2023

Followup needed on artifactIds that end in -plugin: sghill-rewrite/build-user-vars-plugin@23ae524

@sghill
Copy link
Collaborator Author

sghill commented Aug 23, 2023

Some plugins need an unpredictable override: sghill-rewrite/custom-tools-plugin@5d01039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@sghill sghill

Labels
bug Something isn't working enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sghill @timtebeek