Introduce AddTeamToCodeowners Recipe #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sghill
force-pushed
the
feature/codeowners
branch
from
393c6e8 to
7b652fc
Compare
timtebeek
approved these changes
Aug 18, 2023
| return new TreeVisitor<Tree, ExecutionContext>() { | ||
| @Override | ||
| public Tree visit(@Nullable Tree tree, ExecutionContext executionContext, Cursor parent) { | ||
| SourceFile sourceFile = (SourceFile) requireNonNull(tree); |
There was a problem hiding this comment.
Not quite sure when tree would ever be null here; we can hope we don't find out. Did you see this pattern elsewhere?
There was a problem hiding this comment.
I believe so, though I don't recall where. I think it's mainly for telling the IDE to not highlight tree since that's marked @Nullable in the superclass.
There was a problem hiding this comment.
Found it in CreateTextFile
src/main/java/org/openrewrite/jenkins/github/AddTeamToCodeowners.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim te Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
A new recipe has been introduced.
What's your motivation?
Closes #19.
Anything in particular you'd like reviewers to focus on?
The style-matching implementation is done in-recipe, there may be a better way to do this.
Anyone you would like to review specifically?
@timtebeek @basil
Any additional context
Checklist
./gradlew licenseFormat