Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrderImports from JavaxAnnotationsToSpotbugs #11

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

sghill
Copy link
Collaborator

@sghill sghill commented Jul 25, 2023

What's changed?

org.openrewrite.java.OrderImports removed from org.openrewrite.jenkins.JavaxAnnotationsToSpotbugs recipe.

What's your motivation?

Creates too many unrelated changes. This is sometimes viewed as noise, adding friction to potential merges.

Anything in particular you'd like reviewers to focus on?

If there is a way to order imports only in already-changed files, that would be preferred.

Any additional context

Fixes #10.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

Creates too many unrelated changes. Fixes #10.
@sghill sghill self-assigned this Jul 25, 2023
@timtebeek timtebeek added the enhancement New feature or request label Jul 25, 2023
@sghill sghill merged commit 1c1ed3e into main Jul 25, 2023
@timtebeek timtebeek deleted the issue-10 branch July 25, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove OrderImports from JavaxAnnotationsToSpotbugs
2 participants