Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OrderImports from JavaxAnnotationsToSpotbugs #10

Closed
sghill opened this issue Jul 25, 2023 · 0 comments · Fixed by #11
Closed

Remove OrderImports from JavaxAnnotationsToSpotbugs #10

sghill opened this issue Jul 25, 2023 · 0 comments · Fixed by #11
Assignees
@sghill

Comments

@sghill
Copy link
Collaborator

sghill commented Jul 25, 2023

Including org.openrewrite.java.OrderImports changes files otherwise unrelated to this migration and is best left to a separate formatting recipe.

In a review of jenkinsci/build-name-setter-plugin#77, it was considered noise and requested to be reverted.
@sghill sghill self-assigned this Jul 25, 2023
sghill added a commit that referenced this issue Jul 25, 2023
@sghill
JavaxAnnotationsToSpotbugs should not order imports
341b116 
Creates too many unrelated changes. Fixes #10.
@sghill sghill mentioned this issue Jul 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sghill sghill

Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove OrderImports from JavaxAnnotationsToSpotbugs openrewrite/rewrite-jenkins
1 participant
@sghill